Peer is_known robustness #3040
Merged
Peer is_known robustness #3040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @j01tz |
hashmap
approved these changes
Sep 12, 2019
antiochp
added a commit
to antiochp/grin
that referenced
this pull request
Sep 17, 2019
* add some test coverage around peers map (peer_addr hashing impl) * make is_known a bit more robust * fix typos
antiochp
added a commit
to antiochp/grin
that referenced
this pull request
Sep 19, 2019
* add some test coverage around peers map (peer_addr hashing impl) * make is_known a bit more robust * fix typos
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our existing impl of
is_known()for peers returnsfalseif we fail to obtain the read lock on the peers map (we don't know if its known or not so we assume its not known).This is not robust behavior in all situations.
For example - we may be checking if we already know a particular peer address when making some connections to outbound peers at startup time.
If we experience contention of the lock around the peers map we do not want to accidentally attempt to connect to a peer a second time.
This PR changes the
is_known()api to return an error if we cannot get the read lock.This allows the caller to handle this case as they see fit.