BasicAuthMiddleware: Add option to ignore authentication for a particular URI #3037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antiochp
approved these changes
Sep 12, 2019
antiochp
pushed a commit
to antiochp/grin
that referenced
this pull request
Sep 17, 2019
…ular URI (mimblewimble#3037) * api::BasicAuthMiddleware: Add option to ignore authentication for a particular URI * rustfmt
antiochp
pushed a commit
to antiochp/grin
that referenced
this pull request
Sep 19, 2019
…ular URI (mimblewimble#3037) * api::BasicAuthMiddleware: Add option to ignore authentication for a particular URI * rustfmt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Workaround to support:
mimblewimble/grin-wallet#183
In this case, the Wallet's owner API and Foreign API are being run on the same port, which means that authentication and the owner API secret need to be shared with everyone using the owner API. This change adds an option to specify a particular uri for the authentication to ignore, allowing the wallet to run 2 JSON-RPC endpoint routes without requiring authentication for one of them.
Don't think this opens any holes as this checks for the entire path from the root, but would appreciate a once-over to confirm.