New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup deprecation warnings about missing dyn with trait objects #2997

Merged

antiochp merged 1 commit into mimblewimble:master from antiochp:cleanup_deprecation_warnings

Aug 26, 2019

Member

antiochp commented Aug 23, 2019

This PR fixes various deprecation warnings with rust 1.37.0, specifically around trait objects and no explicit dyn -

rustc --version
rustc 1.37.0 (eae3437df 2019-08-13)

   Compiling grin_servers v2.0.1-beta.1 (/antiochp/grin/servers)
warning: trait objects without an explicit `dyn` are deprecated
   --> servers/src/grin/dandelion_monitor.rs:105:16
    |
105 |     adapter: &Arc<DandelionAdapter>,
    |                   ^^^^^^^^^^^^^^^^ help: use `dyn`: `dyn DandelionAdapter`
    |
    = note: #[warn(bare_trait_objects)] on by default


          cleanup deprecation warnings about missing dyn with trait objects

2b15679

antiochp added the task label

quentinlesceller approved these changes

View reviewed changes

Member

quentinlesceller left a comment

Looks good to me 👍

antiochp merged commit dcd405e into mimblewimble:master

antiochp deleted the cleanup_deprecation_warnings branch

August 26, 2019 20:17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

task