simplify broadcast - send to all connected peers #2996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think based on earlier discussions we decided to simply broadcast to all connected peers.
Related - #2985
This PR simplifies the existing "count" logic and does just that.
We used to broadcast as follows -
This is all simplified to just iterate over the connected peers and broadcast to all of them.
The major difference here is we now send headers to many more peers than we used to.
But this was discussed and there is no reason why we should limit this to 8 peers.
There will be an increase in network traffic for new blocks (more headers broadcast) but this should intuitively keep the network healthier as blocks should propagate faster like this.