Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We read the "prune list" from external data (via a txhashset download).
So we need to be a little careful with what we expect this to contain.
Specifically we make assumptions about this being 1-indexed and therefore will never contain a
0
value.This PR adds some robustness around this - we still make the same assumption but we are not a little more defensive in how we deal with it.
saturating_sub(1)
in preference to- 1
to avoid overflows.0
from our 1-indexed prune list when initializing the prune list.assert!
to make logic errors more visible if/when we misuse the prune list