Update intro.md #2975
Update intro.md #2975
Conversation
Significant clarifications, especially in the paragraph where excess value is introduced and the section about kernel offsets.
|
Looks good - I need to have another read through but 👍 |
"Splitting" the blinding factor into *k1* and *k2* is unnecessarily confusing I think. The excess and the offset are really two arbitrary numbers without any mathematical relation to each other. I think I rephrased the section as well as I could without sacrificing any correctness for the sake of simplicity (which I think would be more confusing than helpful).
Transactions are not aggregated by non-mining nodes as well. Removed the part about miners.
|
Really nice that you're working on improving the docs. This is really important for grin, IMHO. I see the changed document has different column wrap. If you have time to rebase to get rid of the conflict that is currently preventing merging, maybe you could also have your text editor redo the line-breaks to match the original more narrow? I'm thinking that if the changes were easier to see, then this update could be easier to get through the review process. |
|
Just fixed the merge conflict. Going to have a thorough review today. |
There was a problem hiding this comment.
Thank you for the pr @rsoltanzadeh! Looking good 👍. I'm approving the PR even if there is a few things that I'd like to discuss (see comment below) but nothing blocking as is.
|
Okay LGTM. |
Significant clarifications, especially in the paragraph where excess value is introduced and the section about kernel offsets.