test: Re-enabled too large block test. Block tests now use ChainTypes::AutomatedTesting #2950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…:AutomatedTesting
hashmap
approved these changes
Jul 16, 2019
|
Excellent, thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The AutomatedTesting chain type has a much smaller max block weight so it's possible to test the size validation in a short amount of time (it takes about one second now).
After enabling AutomatedTesting in the too_large_block test the serialized_size tests started failing as this is a shared global state and the serialized block size is smaller in the AutomatedTesting mode, so I updated the sizes.