Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase peer's send buffer #2931

Merged
merged 1 commit into from
Jun 30, 2019
Merged

Increase peer's send buffer #2931

merged 1 commit into from
Jun 30, 2019

Conversation

hashmap
Copy link
Contributor

@hashmap hashmap commented Jun 28, 2019

When we send a txhashet archive a peer's thread is busy with sending it
and can't send other messages, eg pings. If the network connection is
slow buffer capacity 10 may be not enough, hence the peer's drop.

Safer attempt to address #2929 in 2.0.0, more info #2930

@hashmap
Increase peer's send buffer
5615f1e 
When we send a txhashet archive a peer's thread is busy with sending it
and can't send other messages, eg pings. If the network connection is
slow buffer capacity 10 may be not enough,  hence the peer's drop.

Safer attempt to address mimblewimble#2929 in 2.0.0
@hashmap hashmap added this to the 2.0.0 milestone Jun 28, 2019
@hashmap hashmap requested a review from antiochp June 28, 2019 18:08
@hashmap
Copy link
Contributor Author

hashmap commented Jun 28, 2019 •
edited
Loading

I tested the original version with some additional logging (https://github.com/cyclefortytwo/grin/tree/test-peer-drop) can confirm that this situation (drop a peer because of the full buffer) happens (sorry for a meaningless message):

20190628 22:10:09.366 ERROR grin_p2p::conn - XXX full send buffer
20190628 22:10:59.371 ERROR grin_p2p::conn - XXX full send buffer
20190628 22:10:59.371 ERROR grin_p2p::conn - XXX full send buffer
20190628 22:10:59.371 ERROR grin_p2p::conn - XXX full send buffer
20190628 22:10:59.371 ERROR grin_p2p::conn - XXX full send buffer
20190628 22:10:59.371 ERROR grin_p2p::conn - XXX full send buffer
20190628 22:10:59.371 ERROR grin_p2p::conn - XXX full send buffer
20190628 22:10:59.371 ERROR grin_p2p::conn - XXX full send buffer
20190628 22:10:59.371 ERROR grin_p2p::conn - XXX full send buffer
20190628 22:10:59.371 ERROR grin_p2p::conn - XXX full send buffer
20190628 22:10:59.371 ERROR grin_p2p::conn - XXX full send buffer
20190628 22:10:59.371 ERROR grin_p2p::conn - XXX full send buffer
20190628 22:10:59.371 ERROR grin_p2p::conn - XXX full send buffer
20190628 22:10:59.371 ERROR grin_p2p::conn - XXX full send buffer
20190628 22:11:33.218 ERROR grin_p2p::conn - XXX full send buffer
20190628 22:11:34.415 ERROR grin_p2p::conn - XXX full send buffer
20190628 22:11:35.353 ERROR grin_p2p::conn - XXX full send buffer
20190628 22:11:37.037 ERROR grin_p2p::conn - XXX full send buffer
20190628 22:11:38.045 ERROR grin_p2p::conn - XXX full send buffer
20190628 22:11:39.377 ERROR grin_p2p::conn - XXX full send buffer

antiochp
antiochp approved these changes Jun 30, 2019
View reviewed changes
Copy link
Member

@antiochp antiochp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I'd be good with getting this in 2.0.0 as we are not changing and behavior here (only increasing the limit).

@hashmap hashmap merged commit 66a44f5 into mimblewimble:milestone/2.0.0 Jun 30, 2019
@hashmap hashmap deleted the increase-send-buffer branch June 30, 2019 19:17
hashmap added a commit to cyclefortytwo/grin that referenced this pull request Jun 30, 2019
@hashmap
Increase peer's send buffer (mimblewimble#2931)
8977e02 
When we send a txhashet archive a peer's thread is busy with sending it
and can't send other messages, eg pings. If the network connection is
slow buffer capacity 10 may be not enough,  hence the peer's drop.

Safer attempt to address mimblewimble#2929 in 2.0.0
hashmap added a commit that referenced this pull request Jun 30, 2019
@hashmap
Increase peer's send buffer (#2931) (#2934)
dbd2535 
When we send a txhashet archive a peer's thread is busy with sending it
and can't send other messages, eg pings. If the network connection is
slow buffer capacity 10 may be not enough,  hence the peer's drop.

Safer attempt to address #2929 in 2.0.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antiochp antiochp antiochp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@hashmap @antiochp