[2.x.x] Generate txhashset archives on 720 block intervals. #2919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… of the current txhashset archive
garyyu
reviewed
Jun 27, 2019
| @@ -297,15 +299,17 @@ impl MessageHandler for Protocol { | |||
| sm_req.hash, sm_req.height | |||
There was a problem hiding this comment.
This log has been changed (in master before reverting) as:
debug!(
"handle_payload: txhashset request for {} at {}, response with {} at {}",
sm_req.hash, sm_req.height, txhashset_header.height, txhashset_header_hash,
"handle_payload: txhashset req for {} at {}",
sm_req.hash, sm_req.height
);
garyyu
approved these changes
Jun 27, 2019
garyyu
reviewed
Jun 27, 2019
| let mut genesis = genesis::genesis_dev(); | ||
| let keychain = keychain::ExtKeychain::from_random_seed(false).unwrap(); | ||
| let key_id = keychain::ExtKeychain::derive_key_id(0, 1, 0, 0, 0); | ||
| let reward = reward::output(&keychain, &key_id, 0, false).unwrap(); |
There was a problem hiding this comment.
Ah, some interfaces has been changed and the test code need a bit rework now:
error[E0061]: this function takes 5 parameters but 4 parameters were supplied
--> chain/tests/chain_test_helper.rs:63:15
|
63 | let reward = reward::output(&keychain, &key_id, 0, false).unwrap();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ expected 5 parameters
error[E0061]: this function takes 5 parameters but 4 parameters were supplied
--> chain/tests/chain_test_helper.rs:92:16
|
92 | let reward = libtx::reward::output(keychain, &pk, 0, false).unwrap();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ expected 5 parameters
|
Hi @cadmuspeverell, could you be able to make these changes? However I can copy your branch and do it. |
antiochp
changed the title
|
Closed for #2951. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace #2813. Cause this previous PR was merged on master branch.