Speedup shutdown #2862
Merged
Speedup shutdown #2862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I made an suboptimal (aka stupid) decision to stop and wait for peers one by one which makes shutdown very slow - O(n). This PR decouples sending stop signal from waiting a thread to exit. On top of it in Peers we first send stop signal to all peers and only after that start waiting for them to exit. It gives us a constant time of shutdown in most of the cases.
0xmichalis
approved these changes
May 29, 2019
|
Thanks for finding this 👍 It happened several times when I kill the process, but I didn't realize it's a new "bug" :-) I thought sth was wrong in my system and just use |
garyyu
approved these changes
May 30, 2019
antiochp
added
the
release notes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made an suboptimal (aka stupid) decision to stop and wait for peers
one by one which makes shutdown very slow - O(n). This PR decouples sending
stop signal from waiting a thread to exit. On top of it in Peers we
first send stop signal to all peers and only after that start waiting
for them to exit. It gives us a constant time of shutdown in most of the
cases.