Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TODO in to_edge! macro #2853

Merged
merged 2 commits into from
Jun 3, 2019
Merged

Fix TODO in to_edge! macro #2853

merged 2 commits into from
Jun 3, 2019

Conversation

eupn
Copy link
Contributor

@eupn eupn commented May 27, 2019

This PR fixes TODO in to_edge! macro about its unhygienic usage of T type parameter. The solution is to simply pass type into the macro as a parameter.

@hashmap hashmap merged commit 329dc82 into mimblewimble:master Jun 3, 2019
@antiochp antiochp added this to the 1.1.0 milestone Jun 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavidBurkett DavidBurkett DavidBurkett approved these changes

@hashmap hashmap hashmap approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.
4 participants
@eupn @hashmap @DavidBurkett @antiochp