De/Serialize signatures (for slate consumption) to compressed format rather than raw #2852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavidBurkett
approved these changes
May 27, 2019
antiochp
added
the
release notes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This appears to have been an oversight during development of the custom serialization code for secp primitives to change JSON output from arrays to bytes to hex strings. The original byte array format was being output in compressed format, while the custom serializers were using raw data. This wasn't an intentional change, so it would make sense to ensure the data being output as hex strings is in the same format.
This is only being used by grin_wallet to create slates, and no versions have actually been released with the hex/raw data signature format, so it should be safe to include this in 1.1.0. It will mean inconsistencies between beta versions and the 1.1.0 release, but given 1.1.0 should be released any day, this change shouldn't have too much of a negative impact.