Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get /v1/blocks without merkle_proof #2843

Merged
merged 1 commit into from
May 31, 2019
Merged

Get /v1/blocks without merkle_proof #2843

merged 1 commit into from
May 31, 2019

Conversation

pronvis
Copy link
Contributor

@pronvis pronvis commented May 25, 2019

add flag 'no_merkle_proof' to /v1/blocks api to get blocks without checking merkle proof

@hashmap
Copy link
Contributor

hashmap commented May 27, 2019

Thanks for the contribution! LGTM, would you mind to add a test to https://github.com/mimblewimble/grin-wallet/blob/master/integration/tests/simulnet.rs I know it seems strange, but we moved integration tests to the wallet repo.

@pronvis
Copy link
Contributor Author

pronvis commented May 27, 2019

@hashmap Yep, ofc, I didn't find tests on grin project thats why my PR without tests. But now I know where are they hide :)

@hashmap
Copy link
Contributor

hashmap commented May 27, 2019

@invis87 yeah, this is confusing and less safe, I think we should bring node-specific tests back

@pronvis
Copy link
Contributor Author

pronvis commented May 30, 2019

@hashmap sorry for stupid question, but how can I run integration tests in grin_wallet:

  1. run it
  2. run on top of my changes on grin

I found that integration tests are disabled in grin_wallet :(

But of course I can add tests to "http://{}:{}/v1/blocks/{}?no_merkle_proof" in the same manner as it is done for "http://{}:{}/v1/blocks/{}?compact". If I do so - should it be different PR or... How to do it right :) ?

@hashmap
Copy link
Contributor

hashmap commented May 30, 2019

There is no such thing as a stupid question. We discussed this situation during this week’s dev meeting and decided to move node-related tests back to grin repo. I’d recommend to create an issue to implement this test, we can do it after moving the tests. I’ll test your code manually meanwhile, thanks!

@hashmap hashmap merged commit 2cb3791 into mimblewimble:master May 31, 2019
@pronvis
Copy link
Contributor Author

pronvis commented Jun 2, 2019

@hashmap can you close #1477 please?

@antiochp antiochp added this to the 1.1.0 milestone Jun 5, 2019
@antiochp antiochp added the release notes To be included in release notes (of relevant milestone). label Jun 5, 2019
@antiochp antiochp changed the title get /v1/blocks without merkle_proof Get /v1/blocks without merkle_proof Jun 5, 2019
@antiochp antiochp changed the title Get /v1/blocks without merkle_proof Get /v1/blocks without merkle_proof Jun 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release notes To be included in release notes (of relevant milestone).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants