Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the curve name in one section of intro #2823

Merged
merged 1 commit into from
May 17, 2019
Merged

Fix the curve name in one section of intro #2823

merged 1 commit into from
May 17, 2019

Conversation

hashmap
Copy link
Contributor

@hashmap hashmap commented May 14, 2019

No description provided.

@GandalfThePink
Copy link
Contributor

I think that G is just the generating point and not the curve itself. G can be multiplied, i.e. k * G, but C instead is an equation that specified the curve. I think the old version was fine.

@hashmap
Copy link
Contributor Author

hashmap commented May 15, 2019

@GandalfThePink it seems we both agree that G is not the curve. What I'm trying to fix is exactly that statement: on the elliptic curve _G_,

@GandalfThePink
Copy link
Contributor

Yes, ... I must be colorblind.

I then fully agree with your modification.

@0xmichalis
Copy link
Contributor

Fixes #2808

@hashmap hashmap merged commit 9c32321 into mimblewimble:master May 17, 2019
@hashmap hashmap deleted the fix-curve-intro branch May 17, 2019 20:03
@0xmichalis 0xmichalis mentioned this pull request May 17, 2019
Closed
@antiochp antiochp added this to the 1.1.0 milestone Jun 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GandalfThePink GandalfThePink GandalfThePink approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.
4 participants
@hashmap @GandalfThePink @0xmichalis @antiochp