make sure we use BigEndian when reading numbers via StreamingReader #2821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What if we just switch to blocking io? |
That would be one option that would presumably simplify this. I'm not 100% convinced blocking io is the right solution here. |
ignopeverell
approved these changes
May 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2820.
This PR fixes a narrow part of #2820 where we are not using
BigEndianexplicitly inStreamingReader.This has an additional benefit where we get rid of a couple of levels of indirection. We used to deserialize numbers (
u64etc.) in aStreamingReaderby instantiating a newBinReaderwithin thedeserializecall for each number being deserialized.