Add proofsize check in pow verification #2805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hashmap
approved these changes
May 5, 2019
de1acr0ix
pushed a commit
to btccom/grin
that referenced
this pull request
May 6, 2019
antiochp
added
the
release notes
antiochp
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the only way that solutions are enforced to have length 42 is by function Proof::read at https://github.com/mimblewimble/grin/blob/master/core/src/pow/types.rs#L394-L428
This is rather fragile, and could cause problems if proofs are constructed by other means than deserialization through Proof::read.
A more robust way to check it would be in the core PoW verification functions CuckarooContext::verify and CuckatooContext::verify, which is what this PR adds.
The change has been tested to sync the mainnet chain from scratch.