Simplify peer connection handling #2801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hashmap
reviewed
May 3, 2019
hashmap
reviewed
May 3, 2019
antiochp
changed the title
antiochp
force-pushed
the
peer_connection_simplify
branch
from
61ea67d to
2ea4b91
Compare
hashmap
approved these changes
May 3, 2019
antiochp
force-pushed
the
peer_connection_simplify
branch
from
2ea4b91 to
81b5ddd
Compare
antiochp
added
the
release notes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The peer connection used to be wrapped in an option.
This complicated the initialization of a peer (with active connection) due to the period between creating the peer and assigning the connection to it.
The workaround was the
connection!macro to handle the case where the connection wasNone.This PR simplifies this.
Peer::accept()andPeer::connect()now return a peer with active connection already assigned.We have less special cases to handle like this.