Evict transaction from transaction pool #2797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antiochp
approved these changes
May 3, 2019
| // Get last transaction and remove it | ||
| match bucket_transactions.last() { | ||
| Some(evictable_transaction) => { | ||
| // Remove transaction |
There was a problem hiding this comment.
We should be able use entries.remove() here I think.
There was a problem hiding this comment.
I'm not sure this is doable since we are comparing a PoolEntry with a Transaction.
If both were PoolEntry a remove_item(...) would be possible
(or there is a cheap way to get the index of the PoolEntry that I am missing).
antiochp
reviewed
May 3, 2019
ignopeverell
approved these changes
May 13, 2019
antiochp
added
the
release notes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace #2706 and fix #1417.
Thanks to #2758 we can drastically simplify the eviction process when the transaction pool is full:
bucket_transactionsand remove the last one (No other tx depends on it, it has low fee_to_weight and is unlikely to participate in any cut-through).