Wrap MsgHeader in MsgHeaderWrapper for Known/Unknown msg type support #2791
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a
MsgHeaderWrapper
enum withKnown
andUnknown
variants.Known
variant wraps aMsgHeader
and we process it as before.Unknown
variant wraps amsg_len
and we callread_discard(msg_len)
to discard the unwanted bytes from the stream.If we do encounter an unknown msg type then we do not know how to deserialize it safely.
But we do want to read the bytes (based on
msg_len
) so we can read any subsequent msg correctly off the stream.Resolves #2782.