Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump rand crate to 0.6 (was 0.5) #2790

Merged
merged 1 commit into from
Apr 30, 2019
Merged

bump rand crate to 0.6 (was 0.5) #2790

merged 1 commit into from
Apr 30, 2019

Conversation

antiochp
Copy link
Member

shuffle was deprecated, fix this up

@antiochp
bump rand crate to 0.6 (was 0.5)
ec60bf9 
shuffle was deprecated, fix this up
@antiochp antiochp requested a review from ignopeverell April 30, 2019 15:25
@antiochp
Copy link
Member Author

@ignopeverell want to take a quick look and make sure I have not done something dumb here moving from -

thread_rng().shuffle(&mut res);

to

res.shuffle(&mut thread_rng());

ignopeverell
ignopeverell approved these changes Apr 30, 2019
View reviewed changes
Copy link
Contributor

@ignopeverell ignopeverell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the implementation, they're the same. So should be fine.

@ignopeverell ignopeverell merged commit 6352780 into mimblewimble:master Apr 30, 2019
@antiochp antiochp added this to the 1.1.0 milestone Jun 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ignopeverell ignopeverell ignopeverell approved these changes

@quentinlesceller quentinlesceller quentinlesceller approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@antiochp @quentinlesceller @ignopeverell