Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: a tiny clarification about the point H #2774

Merged
merged 1 commit into from
May 14, 2019

Conversation

maxim-levy
Copy link
Contributor

IMHO, introducing the point H explicitly makes the explanation arguably a bit more clear


name: Pull Request
about: Pull Request checklist
title: ''
labels: ''
assignees: ''


If your PR is a work in progress, please feel free to create it and include a [WIP] tag in the PR name. We encourage everyone to PR early and often so that other developers know what you're working on.

Before submitting your PR for final review, please ensure that it:

  • Includes a proper description of what problems the PR addresses, as well as a detailed explanation as to what it changes
  • Explains whether/how the change is consensus breaking or breaks existing client functionality
  • Contains unit tests exercising new/changed functionality
  • Fully considers the potential impact of the change on other parts of the system
  • Describes how you've tested the change (e.g. against Floonet, etc)
  • Updates any documentation that's affected by the PR

IMHO, introducing the point _H_ explicitly makes the explanation arguably a bit more clear
@ignopeverell ignopeverell merged commit 136a4ba into mimblewimble:master May 14, 2019
@antiochp antiochp added this to the 1.1.0 milestone Jun 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants