Relax p2p rules around matching protocol versions #2764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antiochp
force-pushed
the
relax_protocol_version
branch
from
b271759 to
119a97d
Compare
|
cc @DavidBurkett And we can reintroduce any constraints on "legacy" or minimum versions as necessary later. |
|
So the way it was coded before, any increase in protocol version would've caused a network split? That doesn't seem very useful 😁. Glad you noticed this. |
|
Yeah it was just placeholder code but inflexible placeholder code... |
|
We should get this merged in for |
ignopeverell
approved these changes
Apr 24, 2019
antiochp
added
the
release notes
antiochp
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently only allow peer connections if the "protocol version" is an exact match between us and the peer.
We will start refusing peer connections in either direction if we attempt to increment any protocol version numbers on the network.
This PR removes this rule and permits peer connections for any combination of protocol version values.
If/when we need to introduce thresholds or incompatible version checking in the future we can, but for now we just accept arbitrary version numbers.
Also - expose our version number via the TUI.