Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make field in tx_body public #2762

Merged
merged 1 commit into from
Apr 19, 2019
Merged

make field in tx_body public #2762

merged 1 commit into from
Apr 19, 2019

Conversation

yeastplume
Copy link
Member

Required for slate conversion logic in mimblewimble/grin-wallet#85

antiochp
antiochp approved these changes Apr 19, 2019
View reviewed changes
Copy link
Member

@antiochp antiochp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine.

One thing we may want to consider is adding a fn to access this rather than making the field itself pub?

But I'm good with this either way.

@yeastplume
Copy link
Member Author

👍 thanks!

@yeastplume yeastplume merged commit 865b9b6 into mimblewimble:master Apr 19, 2019
@yeastplume yeastplume deleted the pub_transaction_body branch May 20, 2019 08:19
@antiochp antiochp added this to the 1.1.0 milestone Jun 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antiochp antiochp antiochp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@yeastplume @antiochp