cleanup how we deal with fixed size vs variable size data files #2757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antiochp
changed the title
|
Will hold off merging this. Guessing we merge this onto |
antiochp
changed the title
introduce a SizeInfo enum (to replace two options)
antiochp
force-pushed
the
cleanup_option_size
branch
from
411fa8a to
a462ac5
Compare
ignopeverell
approved these changes
Apr 24, 2019
antiochp
added
release notes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SizeInfoenum with 2 variants -SizeInfo::FixedSizeSizeInfo::VariableSizeThe
VariableSizevariant maintains asize_fileinternally.This replaces the current impl where we pass around a couple of seemingly unrelated options which made it unnecessarily complicated.
Refactor only - no change to how any of this works (enum replaces two existing options).