Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase peer max count significantly #2754

Merged
merged 2 commits into from
Apr 24, 2019
Merged

Increase peer max count significantly #2754

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3a45a26
Increase peer max count significantly
ignopeverell Apr 15, 2019
b4b1b1d
Reduce limit to 125, like bitcoin
ignopeverell Apr 24, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion config/src/comments.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,7 +228,7 @@ fn comments() -> HashMap<String, String> {
#ban_window = 10800

#maximum number of peers
#peer_max_count = 25
#peer_max_count = 125
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this option be uncommented? Otherwise, it's not really a default but more like a suggestion.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or is the default driven by PEER_MAX_COUNT below?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default is driven by PEER_MAX_COUNT. Ideally config comments that are generated should be driven by that, as @antiochp mentioned, but it's a little out of scope for this PR.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Opened #2781


#preferred minimum number of peers (we'll actively keep trying to add peers
#until we get to at least this number
Expand Down
2 changes: 1 addition & 1 deletion p2p/src/types.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ pub const MAX_LOCATORS: u32 = 20;
const BAN_WINDOW: i64 = 10800;

/// The max peer count
const PEER_MAX_COUNT: u32 = 25;
const PEER_MAX_COUNT: u32 = 125;

/// min preferred peer count
const PEER_MIN_PREFERRED_COUNT: u32 = 8;
Expand Down