-
Notifications
You must be signed in to change notification settings - Fork 992
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[1.1.0] Support variable size PMMR (optional size_file) #2734
[1.1.0] Support variable size PMMR (optional size_file) #2734
Conversation
Support fixed size data file via an optional elmt_size. Support variable size data file via optional size_file.
for windows fix,
|
@yeastplume thanks for debugging this. I'll fix and push again later on. |
Besides that, it all looks good and glad you've done this. I won't pretend I've exhaustively looked through all the rewind and pruning logic changes, but I know how hairy that gets and trust it was sufficiently fiddly to get working. Do we want to get this into 1.1.0? Given the changes are all underneath, we can do a beta 2 of the server portion. I do think there is still an issue with sync on Windows that might require more changes, give me a day or so to investigate. |
I think its worth considering if we get to the point where Windows sync appears robust/fixed. |
Absolutely fine on windows now, turns out my issues were local. Happy to merge this and do a beta 2 of the grin server (perhaps another merge from master to get a couple of other bits and pieces in) |
Rebasing changes from #2733 across to 1.1.0 branch.