Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add first_seen field to LivePeerInfo #2724

Merged
merged 1 commit into from
Apr 4, 2019
Merged

Add first_seen field to LivePeerInfo #2724

merged 1 commit into from
Apr 4, 2019

Conversation

hashmap
Copy link
Contributor

@hashmap hashmap commented Apr 2, 2019

Totally nice to have, I personally found it useful. Also could be used
to support FIFO peer list.

Also some refactoring

@hashmap
Add first_see field to LivePeerInfo
50da954 
Totally nice to have, I personally found it useful. Also could be used
to support FIFO peer list.
@hashmap hashmap changed the title Add first_see field to LivePeerInfo Add first_seen field to LivePeerInfo Apr 2, 2019
This was referenced Apr 3, 2019
Closed
Open
antiochp
antiochp approved these changes Apr 4, 2019
View reviewed changes
Copy link
Member

@antiochp antiochp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely useful 👍.

To be clear - this is "first seen" in this session i.e. since the most recent node restart?

@hashmap
Copy link
Contributor Author

hashmap commented Apr 4, 2019

@antiochp correct

@hashmap hashmap merged commit 1b7d710 into mimblewimble:master Apr 4, 2019
@hashmap hashmap deleted the peer-first-seen branch April 4, 2019 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antiochp antiochp antiochp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hashmap @antiochp