[1.1.0] (JSON only) Serialization of TxKernel u64s as strings #2698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why not just require it to always be a string? Since this is a 'V2' API, there's no requirement of backward compatibility. |
|
It's just as easy to accept both and might remove an annoyance for clients that can deal with u64 literals |
antiochp
added
the
release notes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of wallet V2 API, I'm ensuring that all u64 fields returned by the API are serialized into JSON as strings as opposed to literals, as it's not guaranteed that consumers will know what to do with a u64 literal (javascript, for instance). TxKernel is embedded in the JSON slate, so the custom serializer needs to be added to it.
Note that the API will still be able to accept literals in u64 fields on deserialization, it will just produce them as strings by default on serialization.