Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable hooks during sync #2695

Merged
merged 3 commits into from
Mar 23, 2019
Merged

Disable hooks during sync #2695

merged 3 commits into from
Mar 23, 2019

Conversation

mcdallas
Copy link
Contributor

Do not trigger events during sync to avoid DoSing the recipient.

Closes #2692

antiochp
antiochp reviewed Mar 21, 2019
View reviewed changes
Copy link
Member

@antiochp antiochp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment about headers_received (I don't think we need to hook into this).
Otherwise 👍.

servers/src/common/adapters.rs Outdated Show resolved Hide resolved
@antiochp antiochp self-requested a review March 22, 2019 21:28
antiochp
antiochp approved these changes Mar 22, 2019
View reviewed changes
Copy link
Member

@antiochp antiochp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@antiochp antiochp added this to the 1.0.3 milestone Mar 22, 2019
@mcdallas
Copy link
Contributor Author

@antiochp that can't go into 1.0.3, all the hook stuff are in the 1.1.0 branch

@ignopeverell ignopeverell modified the milestones: 1.0.3, 1.1.0 Mar 23, 2019
@ignopeverell ignopeverell merged commit c263884 into mimblewimble:milestone/1.1.0 Mar 23, 2019
@quentinlesceller quentinlesceller mentioned this pull request Mar 26, 2019
Closed
@antiochp antiochp added the release notes To be included in release notes (of relevant milestone). label Jun 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antiochp antiochp antiochp approved these changes

Assignees
No one assigned
Labels
enhancement release notes To be included in release notes (of relevant milestone).
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@mcdallas @antiochp @ignopeverell