Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove some unwrap/expect in chain crate #2621

Merged
merged 2 commits into from
Feb 25, 2019
Merged

Remove some unwrap/expect in chain crate #2621

merged 2 commits into from
Feb 25, 2019

Conversation

hashmap
Copy link
Contributor

@hashmap hashmap commented Feb 24, 2019

Also make error management more consistent

@hashmap
Return Result instead of calling expect in root()
cd46648 
It would kill peer's thread. Perhaps we should ban this peer as
malicious.
@hashmap
Remove some unwraps
9ff8d03
@hashmap hashmap added this to the 1.0.2 milestone Feb 24, 2019
@hashmap hashmap added the task label Feb 24, 2019
ignopeverell
ignopeverell approved these changes Feb 25, 2019
View reviewed changes
Copy link
Contributor

@ignopeverell ignopeverell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice little cleanup, thanks!

@ignopeverell ignopeverell merged commit e71eca1 into mimblewimble:master Feb 25, 2019
i1skn pushed a commit to cyclefortytwo/grin that referenced this pull request Apr 2, 2019
@hashmap @i1skn
Remove some unwrap/expect in chain crate (mimblewimble#2621)
60087ae 
* Return Result instead of calling expect in root(). It would kill peer's thread. Perhaps we should ban this peer as malicious.
* Remove some unwraps
@hashmap hashmap deleted the check-root branch April 4, 2019 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ignopeverell ignopeverell ignopeverell approved these changes

Assignees
No one assigned
Labels
task
Projects
None yet
Milestone
1.0.2
Development

Successfully merging this pull request may close these issues.
2 participants
@hashmap @ignopeverell