Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove wallet code [1.1.0] #2593

Merged
merged 10 commits into from
Feb 21, 2019
Merged

Remove wallet code [1.1.0] #2593

merged 10 commits into from
Feb 21, 2019

Conversation

yeastplume
Copy link
Member

@yeastplume yeastplume commented Feb 18, 2019 •
edited
Loading

which is now in https://github.com/mimblewimble/grin-wallet

Notes:

  • A couple of small simple structs (CbData and BlockFees) are just cut and paste from the wallet into mine_block.rs where needed. They're just for serialization purposes so a don't think there's a need to try and refactor anything over this.
  • It might worth removing the server command from grin and simplifying command line args now, but we can leave that for another PR.
  • tests in the server crate that use both the server and wallet are moved into a separate integration crate for now. It made more sense dependency-wise to put this crate into the grin-wallet project for now, but we're going to need a better strategy around these tests.

@yeastplume yeastplume changed the title [WIP] Remove wallet code Remove wallet code Feb 18, 2019
@yeastplume yeastplume changed the title Remove wallet code Remove wallet code [1.1.0] Feb 18, 2019
@yeastplume yeastplume added this to the 1.1.0 milestone Feb 18, 2019
@yeastplume
Copy link
Member Author

Ready for review (if anyone wants to). Will give it a couple of days then merge.

@yeastplume yeastplume merged commit ea4b4fc into mimblewimble:milestone/1.1.0 Feb 21, 2019
@yeastplume yeastplume deleted the wallet_split branch March 4, 2019 10:04
@antiochp antiochp added the release notes To be included in release notes (of relevant milestone). label Jun 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement release notes To be included in release notes (of relevant milestone).
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@yeastplume @antiochp