chore/docs: eliminate warnings #2583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@JeremyRubin sorry, you need to rebase, good news it must be only on place to update in |
…ay_newtype macro traits into impl_array_netype_index
JeremyRubin
force-pushed
the
refactor-eliminate-warnings
branch
from
f71e88b to
86ed21e
Compare
|
nw. Rebased |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eliminates a few more documentation compiler warnings.
Replaces trim_right with trim_end (trim_right deprecates at 1.33.0, trim_end introduced at 1.30.0, we ask for 1.31+ in the build.md.
Moves the macro newtype array indexing trait impl into the right spot.
edit: documents an unhygenic macro use in to_edge