Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API handlers refactoring #2572

Merged
merged 1 commit into from
Feb 15, 2019
Merged

API handlers refactoring #2572

merged 1 commit into from
Feb 15, 2019

Conversation

hashmap
Copy link
Contributor

@hashmap hashmap commented Feb 13, 2019 •
edited
Loading

This PR introduces QueryParams to abstarct low-level parameter parsing in many handlers.
Also adds some API tests.

@hashmap hashmap added this to the 1.0.2 milestone Feb 13, 2019
@hashmap
Refactor API handlers
c1f3225 
Also add some API tests
@hashmap hashmap force-pushed the api-handler-refactor branch from e865def to c1f3225 Compare February 15, 2019 15:44
@hashmap hashmap changed the title [WIP] Api handlers refactoring API handlers refactoring Feb 15, 2019
@hashmap
Copy link
Contributor Author

hashmap commented Feb 15, 2019

Ready for review. Pool API tests are still missing, but they worth a separate PR

ignopeverell
ignopeverell approved these changes Feb 15, 2019
View reviewed changes
Copy link
Contributor

@ignopeverell ignopeverell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup!

@hashmap hashmap merged commit ac6ed71 into mimblewimble:master Feb 15, 2019
@hashmap hashmap deleted the api-handler-refactor branch April 4, 2019 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ignopeverell ignopeverell ignopeverell approved these changes

Assignees
No one assigned
Labels
task
Projects
None yet
Milestone
1.0.2
Development

Successfully merging this pull request may close these issues.
2 participants
@hashmap @ignopeverell