refactor: reserve capacity in aggregate #2568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't mean to inundate review with low hanging fruit, but I've just been fixing/cleaning stuff as I see it reading through the codebase.
In transaction aggregation, we add a bunch of stuff to unreserved vecs. This can be slow-ish as when we realloc we end up having to move stuff and wasteful because we may also over allocate (e.g., memory doubling). It really depends on the implementation.
We care about making this faster because it's in the path of relay and in the path of pools creating blocks.
Allocating ahead of time is simple enough.