fix: false positive wallet tests #2539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hashmap
reviewed
Feb 8, 2019
| @@ -366,10 +366,10 @@ fn perform_restore(test_dir: &str) -> Result<(), libwallet::Error> { | |||
| fn wallet_restore() { | |||
| let test_dir = "test_output/wallet_restore"; | |||
| if let Err(e) = setup_restore(test_dir) { | |||
There was a problem hiding this comment.
Why not setup_restore(test_dir).expect("Libwallet Error")? It is shorter and does almost the same, panic will print out the stacktrace. Also below
|
Hm, please ignore my comment, I see that this error handling pattern is common, perhaps we can fix it in a separate pr (and keep backtrace if we like it) |
|
Ahh, good catch, the position of finalize would have changed recently. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two tests in the wallet were actually failing, we were just ignoring them. This fixes it.