refactor: use less memory in verifier_cache by storing zero-sized type instead of bool #2536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e instead of bool
ignopeverell
approved these changes
Feb 6, 2019
|
\o/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the presence of the entry is sufficient to show that it verified true, we no longer need to store a bool type.
A node in the LRU Cache's Map is 2 pointers, the key, and then the value. Via padding this works out to cost 4 bytes for the bool. This represents a total memory savings of 0.4 MB, which is not terribly much, but nice to do.
This PR also removes the use of
.unwrap_or(&mut false)when checking for entries.