Move slate code from core/libtx to wallet/libwallet #2533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
mmmm I'm almost done with working on backwards compatible serailzation, what do you think is the best way to combine the changes? |
|
This is just moving stuff around so going to merge. |
|
Sorry didn’t see that comment before merging... unfortunately I stuck you with the merge now, but hopefully shouldn’t be too bad |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In anticipation of splitting the wallet off from grin, move Slate code from core to wallet crate. The functionality remaining in 'core/libtx' should be things that are unlikely to change much without consensus changes, while the Slate will need more flexibility.