Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix wallet --data-dir flag #2517

Merged
merged 1 commit into from
Feb 5, 2019
Merged

fix wallet --data-dir flag #2517

merged 1 commit into from
Feb 5, 2019

Conversation

e-max
Copy link
Contributor

@e-max e-max commented Feb 2, 2019

In the grin.yml a flag which allows to pass a path to a directory with wallet data defined as

        - data_dir:
            help: Directory in which to store wallet files
            short: dd
            long: data_dir
            takes_value: true

However in code we expected this flag to be named dir.

@hashmap hashmap added the bug label Feb 2, 2019
@hashmap hashmap mentioned this pull request Feb 5, 2019
Closed
@hashmap hashmap merged commit 4eba13a into mimblewimble:master Feb 5, 2019
@hashmap hashmap deleted the fix_data_dir_flag branch February 5, 2019 06:58
@casey
Copy link
Contributor

casey commented Feb 5, 2019

Thank you for the fix! ^_^

@ignopeverell ignopeverell added this to the 1.0.2 milestone Feb 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hashmap hashmap hashmap approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
1.0.2
Development

Successfully merging this pull request may close these issues.
4 participants
@e-max @casey @hashmap @ignopeverell