Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set max number of connections for peer db #2506

Merged

Conversation

hashmap
Copy link
Contributor

@hashmap hashmap commented Jan 31, 2019

Use max_peers value for that if set. By default LMDB limit is 126, which is not enough for less than 200 peers on my node.

Use max_peers value for that if set. By default LMDB limit is 126, which is not enough for less than 200 peers on my node.
@antiochp
Copy link
Member

antiochp commented Feb 1, 2019

Is this happening even after disabling thread local storage for the connections?

@hashmap
Copy link
Contributor Author

hashmap commented Feb 1, 2019

@antiochp yes, starting closer to 180 peers (which is improvement anyway), it seems we process more than 126 requests in parallel, but with this fix I have 226 peers with no panics.

@antiochp
Copy link
Member

antiochp commented Feb 1, 2019

Related - https://twitter.com/armon/status/534867803426533376 (And I trust the terraform folks to know what they are talking about).

Copy link
Member

@antiochp antiochp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Seems like a reasonable way of getting an approximate max reader count.

@ignopeverell ignopeverell added this to the 1.0.1 milestone Feb 1, 2019
@ignopeverell ignopeverell merged commit 267c706 into mimblewimble:master Feb 1, 2019
@hashmap hashmap deleted the peer-db-max-readers branch April 4, 2019 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants