-
Notifications
You must be signed in to change notification settings - Fork 992
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework "bucket transactions" logic (buckets are now weight limited) #2487
Conversation
I'm planning to spend some time adding some test coverage for this. |
f6c8642
to
cdc7cd8
Compare
@ignopeverell Reworked this a bit more. Added a new Also added some test coverage for mining blocks at the max_block_weight limit from the txpool. So "preparing mineable transactions" from the txpool now takes the miners max block weight config into account when bucketing and aggregating the txs. This PR got bigger than I originally anticipated but there's no clear way of splitting this up in a meaningful way. Thoughts? |
not yet in use anywhere...
… weight limit introduce AsLimitedTx{max_weight} so we can build artifically small blocks (per mining config)
we do not need to account for coinbase reward here (tx vs block)
e088e41
to
95c56fd
Compare
Still looks good to me but looks like the new test is failing? |
Some tests in the wallet cli are failing - I'm guessing its to do with the lower block weight limit in the test chain_type.
|
Final testing on usernet and things look good. |
Resolves #2456.
This PR fixes 2 issues present in our current
prepare_mineable_transactions
implementation.Specifically around how we "bucket" dependent transactions together.
Proposed Implementation -