clean the unused p2p sockets (i.e. not in peers list) #2298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ignopeverell
reviewed
Jan 6, 2019
| @@ -191,6 +201,25 @@ impl Server { | |||
| false | |||
| } | |||
|
|
|||
| fn clean_lost_sockets(&self, sockets: &mut HashMap<SocketAddr, TcpStream>) { | |||
There was a problem hiding this comment.
Perhaps add a code comment here outlining the NAT issue and why this direct connection tracking and cleanup is necessary? This way we won't forget why this is required right now, and what sort of improvements will be needed to make this unnecessary.
|
If no more comments on this PR, i will merge it soon, since I'm still suffering on that full connections problem :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draw half of #2287 to here:
When a connected socket is not in our active peers list, it becomes a lost peer and we never have chance to use it for sending, and it brings us a security risk that we connected an "invisible" peer (or peers), this "invisible" peer still can send us something!
This PR will kill this risk.