feature: Enable setting a node address for a dandelion peer #2263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xmichalis
reviewed
Dec 31, 2018
config/src/comments.rs
Outdated
| @@ -230,6 +230,10 @@ fn comments() -> HashMap<String, String> { | |||
|
|
|||
| # 15 = Bit flags for FULL_NODE | |||
| #This structure needs to be changed internally, to make it more configurable | |||
|
|
|||
| # A prefered dandelion_peer, mainly used for testing dandelion | |||
p2p/src/peers.rs
Outdated
| "Successfully updated Dandelion relay to: {}", | ||
| peer.info.addr | ||
| ); | ||
| match &self.config.dandelion_peer { |
There was a problem hiding this comment.
This would likely look nicer (and more idiomatic) if you first looked for and assigned the peer your want to set as relay, and then did the set on that. Look for the find method from Iterator.
|
Awesome, thanks for the improvement! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So this should address #1250
I don't have too much experience with rust so not sure if this is the right way to do it.
I also don't have much idea as to the best way to test this, what's the best way to go about it?