Support TLS in ApiServer #1565
Merged
Support TLS in ApiServer #1565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is ground work to support TLS in Grin APIs (like wallet ot node). Particular API implemention needs to decide if TLS is used or not and pass certificate data etc. * P12 format support * New method to start TLS server * Transparent TLS support in API client (depends on URL scheme http/https) * Refactoring * Initial support for graceful shutdown (commentred out int this PR, unstable for now) * API server tests (TLS server test is disabled by default, hyper client rejects self-signed certificates, so extra step is needed to install local CA (I used mkcert)
|
Merging after discussing in gitter |
|
Is there any documentation on how to use this? Do I need to do anything config-wise or will a new node use it by default? |
|
@Kargakis Next PR from HashMap should enable this functionality. |
|
@Kargakis There will be for sure. This PR doesn't introduce TLS support for node nor wallet, just enables it on the low level. Next pr(s) will add options to configure it and enable in user facing APIs. TLS will be optional because it requires extra steps which are not feasible for some users, like getting a certificate and domain name (or getting a cert for IP, which is also problematic) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a ground work to support TLS in Grin APIs (like wallet or node). Particular API implementation needs to decide if TLS is used or not and pass certificate data etc.