Rust Cuckatoo for verifier and test-miner #1558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
core/src/pow/cuckatoo.rs
Outdated
| pub fn byte_count(&self) -> Result<u64, Error> { | ||
| Ok(2 | ||
| * self.max_edges.to_u64().ok_or(ErrorKind::IntegerCast)? | ||
| * mem::size_of::<Link<T>>() as u64 + mem::size_of::<T>() as u64 * 2 * self.max_nodes) |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
… in advance of trait refactoring
…ctor for cuckatoo 29
yeastplume
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this is ready and okay to merge now. What I ended up doing is:
PoWContexttrait, that can be instantiated with either a Cuckoo or Cuckatoo context (or whatever comes along), and making sure this trait is used throughout.Added some Cuckatoo 29 test vectors (should add more as we get them) and all appear to be consistent with the latest @tromp output.
@ignopeverell have a look over it when you can (or just hit the 'merge' button if you're okay with it)