-
Notifications
You must be signed in to change notification settings - Fork 990
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
default log levels in config file (revert breaking change) #3117
Comments
For context this is what we see with previous code and new default config file -
|
It's a bit awkward because now we are using the log levels from the log crate, which when serialised are upper case. And the config file is generated by just serialising the config struct that has LogLevels as fields. Couple of options, neither of which I particularly like.
Can we definitely not allow the change? Given that it only breaks if you used new code to generate the config file then reverted to a previous code version. |
Either 1 or 2 would work fine here I think. It makes sense why this happened but we should avoid introducing breaking changes like this for little or no benefit. Maybe the default value for these logging config entries simply post-process to get the capitalization to follow the existing format. |
…rst letter of log level in config file
We tweaked log level config here - #3064
It used to be
Info
but now we also supportINFO
.But - we now generate config file with default entries like -
These actually introduce a breaking change with previous code which does not support them
where
Info
is supported, notINFO
.We should revert the config file generation to add default log level consistent with previous behavior (and also consistent with config file comments).
The text was updated successfully, but these errors were encountered: