-
Notifications
You must be signed in to change notification settings - Fork 990
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
In some cases Stratum server reads part of the message and ignores it #2524
Labels
Comments
hashmap
added a commit
to cyclefortytwo/grin
that referenced
this issue
Feb 4, 2019
If WouldBlock error happens Stratum server drops part of a message to read or write. This PR inroduces a worker's buffer to store partially read message which will be completed next time. For write the existing util function is used. Fixes mimblewimble#2524
de1acr0ix
pushed a commit
to btccom/grin
that referenced
this issue
Feb 7, 2019
If WouldBlock error happens Stratum server drops part of a message to read or write. This PR inroduces a worker's buffer to store partially read message which will be completed next time. For write the existing util function is used. Fixes mimblewimble#2524
hashmap
added a commit
that referenced
this issue
Feb 12, 2019
If WouldBlock error happens Stratum server drops part of a message to read or write. This PR inroduces a worker's buffer to store partially read message which will be completed next time. For write the existing util function is used. Fixes #2524
Ah, the "appends" part is worth mentioning, yes and thank you. But then your comment about the server read should be:
Thanks again for the explanation. |
@bladedoyle you are right, as you can see it has |
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
At this moment server reads
jsonrpc " : " 2 . 0 " }
. It drops the first part of the message here https://github.com/mimblewimble/grin/blob/master/servers/src/mining/stratumserver.rs#L179if read operation is about to block.
The text was updated successfully, but these errors were encountered: