Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wallet coin selection can build a tx that exceeds max_block_weight #2510

Closed
antiochp opened this issue Feb 1, 2019 · 1 comment · Fixed by #2546
Closed

Wallet coin selection can build a tx that exceeds max_block_weight #2510

antiochp opened this issue Feb 1, 2019 · 1 comment · Fixed by #2546
Labels
enhancement good first issue help wanted

Comments

@antiochp
Copy link
Member

antiochp commented Feb 1, 2019

This was not really an issue until we allowed max_block_weight to be configured per chain_type.

UserTesting and AutomatedTesting now define an artificially low max_block_weight to make testing blocks and txs at the block weight limit more convenient.

The coin selection logic (and overall tx building logic) should take max_block_weight into consideration to ensure txs are below the max permissible weight.

Not a huge issue right now but it does mean the default coin selection strategy can build invalid txs on UserTesting (workaround is to specify -s smallest).
@i1skn
Copy link
Contributor

i1skn commented Feb 4, 2019

I would like to work on this one

i1skn added a commit to cyclefortytwo/grin that referenced this issue Feb 8, 2019
@i1skn
fix mimblewimble#2510: wallet coin selection respects max_block_weight
039e965 
Deprecate "soft" max_outputs limit and introduce "hard" max_outputs
limit based on max_block_weight.
@i1skn i1skn mentioned this issue Feb 8, 2019
Merged
ignopeverell pushed a commit that referenced this issue Feb 12, 2019
@i1skn @ignopeverell
fix: wallet coin selection respects max_block_weight (#2546)
aa4f44b 
* fix #2510: wallet coin selection respects max_block_weight

Deprecate "soft" max_outputs limit and introduce "hard" max_outputs
limit based on max_block_weight.

* Fix tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement good first issue help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: wallet coin selection respects max_block_weight cyclefortytwo/grin
2 participants
@i1skn @antiochp