Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make genesis coinbase easier to restore and spend #2216

Closed
ignopeverell opened this issue Dec 23, 2018 · 3 comments
Closed

Make genesis coinbase easier to restore and spend #2216

ignopeverell opened this issue Dec 23, 2018 · 3 comments
Labels

Comments

@ignopeverell
Copy link
Contributor

Currently it looks like the restore process gets the derivation wrong, leading the an output being properly detected but then setup with the wrong key.

@ignopeverell ignopeverell added this to the Floonet-relaunch milestone Dec 23, 2018
@jaspervdm
Copy link
Contributor

I wonder if this is switch commitment related, will investigate..

@ignopeverell
Copy link
Contributor Author

After some help from @yeastplume, he found that nugget:

let key_id = Identifier::from_serialized_path(3u8, &info.message.as_bytes());

I was generating the genesis coinbase with 2-depth path so didn't work so well. Hardcoding restore to use a 2-depth path instead of 3 produced a matching commitment.

ignopeverell added a commit to ignopeverell/grin that referenced this issue Dec 26, 2018
@ignopeverell
Copy link
Contributor Author

Fixed by #2230

ignopeverell added a commit that referenced this issue Dec 26, 2018
* Fix couple floonet loose ends. Fixes #2216
* Doc fix for sig message
ignopeverell added a commit that referenced this issue Dec 28, 2018
*  Fix secondary scaling bugs;  rename is_testnet -> is_floonet (#2215)
* add global::is_mainnet()
* use it to change pre-genesis pow type
* rename is_testnet -> is_floonet
* Support multiple chain configurations (#2217)
* Support multiple chain configurations
Supports generating the proper configuration for each chain type
(mainnet, floonet, usernet). Will run them by default under
their respective root directory (~/.grin/main, ~/.grin/floo, etc).
Assigned default ports for mainnet, overriding them to keep Floonet
ports unchanged.
For now, starting on mainnet will abort.
* Fixed usernet command line help message. Fixes #2217
* Differing magic numbers for each chain type (#2208)
* stick to e=H(R|P|m) when use schnorr signature (#2200)
* stick to e=H(R|P|m) when use schnorr signature
* (1)add verify_slate_messages for wallet receive (2)log the message content
* remove debug log on verify_slate_messages
* verify the sender's message signature when receive_tx in wallet listen
* Revert "remove debug log on verify_slate_messages"

This reverts commit 65ea32a.

* Revert "rustfmt"

This reverts commit c380ab9.

* Revert "(1)add verify_slate_messages for wallet receive (2)log the message content"

This reverts commit 9584ca7.

* [re-floonet] Keychain Floonet BIP32 version/network option (#2235)

* add 'is_floonet' property to keychain
* fix hex encoding and tests

* Fix couple floonet loose ends (#2230)

* Fix couple floonet loose ends. Fixes #2216
* Doc fix for sig message

* Refuse unkown kernel features (#2244)

* Minor: magic number change for re-floonet

* Set pre genesis is_secondary to true (#2247)

* Minor: tx validation error display underlying

* New floonet genesis

* genesis rustfmt

* Use chain-specific config for wallet toml gen

* Fix default wallet_listener_url

* New more reasonable genesis block, bumped version

* genesis rustfmt

* Couple minor fixes to genesis generation script
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants