fix: fraud peer ban doesn't work in some cases (#2867)

mimblewimble · May 31, 2019 · e345405 · e345405
1 parent 56b62a3
commit e345405
Showing 1 changed file with 2 additions and 5 deletions.
diff --git a/servers/src/grin/sync/header_sync.rs b/servers/src/grin/sync/header_sync.rs
@@ -143,13 +143,10 @@ impl HeaderSync {
 				if let Some(ref stalling_ts) = self.stalling_ts {
 					if let Some(ref peer) = self.syncing_peer {
 						match self.sync_state.status() {
-							SyncStatus::HeaderSync {
-								current_height: _,
-								highest_height,
-							} => {
+							SyncStatus::HeaderSync { .. } | SyncStatus::BodySync { .. } => {
 								// Ban this fraud peer which claims a higher work but can't send us the real headers
 								if now > *stalling_ts + Duration::seconds(120)
-									&& highest_height == peer.info.height()
+									&& header_head.total_difficulty < peer.info.total_difficulty()
 								{
 									self.peers
 										.ban_peer(peer.info.addr, ReasonForBan::FraudHeight);