we expect unspent outputs but play it safe #517
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #516
We call the
get_unspent_outputs
api and expect to receive a collection of unspent outputs.This is a reasonable assumption but we are brittle on the receiving/parsing side as each output in the response must contain a block height. If we receive a spent output for any reason the wallet is rendered inoperable as we can no longer refresh outputs.
This PR adds a (hopefully redundant) level of robustness by explicitly filtering out spent outputs from the list returned by the api.
See #516 for some background where the node api was inadvertently changed to return spent and unspent outputs, causing the wallet to fail.